Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pnpm patch in /react instead of patch-package #2661

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Aug 28, 2024

Changes:
Migrates from patch-package to pnpm patching for @cloudscape-design/board-components, adding custom CSS classes and className prop support.

Key updates:

  • Removes patch-package dependency and postinstall script
  • Adds pnpm patching configuration for @cloudscape-design/board-components
  • Adds className prop support to Board component
  • Adds custom CSS classes with bai_ prefix for board placeholders and grid items

Copy link

graphite-app bot commented Aug 28, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:M 30~100 LoC label Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 5.29% 395/7462
🔴 Branches 4.59% 237/5165
🔴 Functions 3.16% 78/2466
🔴 Lines 5.21% 380/7295

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 0822b3b

@ironAiken2 ironAiken2 force-pushed the chore/pnpm-patch-react-project branch from 73478cb to 94687ed Compare November 18, 2024 04:56
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Nov 18, 2024
@ironAiken2 ironAiken2 force-pushed the chore/pnpm-patch-react-project branch from 94687ed to f4d19c9 Compare November 18, 2024 05:28
@ironAiken2 ironAiken2 changed the base branch from main to e2e/update-related-to-neo-mainlayout November 18, 2024 05:28
@ironAiken2 ironAiken2 linked an issue Nov 18, 2024 that may be closed by this pull request
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch 5 times, most recently from 6678e6d to f288411 Compare November 20, 2024 07:21
Base automatically changed from e2e/update-related-to-neo-mainlayout to main November 20, 2024 07:24
@yomybaby yomybaby marked this pull request as ready for review November 20, 2024 08:51
@yomybaby yomybaby force-pushed the chore/pnpm-patch-react-project branch from f4d19c9 to 44ef647 Compare November 20, 2024 08:54
@ironAiken2 ironAiken2 force-pushed the chore/pnpm-patch-react-project branch from 44ef647 to 844bc22 Compare November 20, 2024 08:55
@yomybaby yomybaby marked this pull request as draft November 20, 2024 08:56
@yomybaby yomybaby force-pushed the chore/pnpm-patch-react-project branch from 844bc22 to 7d362f8 Compare November 20, 2024 09:06
@yomybaby yomybaby marked this pull request as ready for review November 20, 2024 09:07
@yomybaby yomybaby requested a review from ironAiken2 November 20, 2024 09:07
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Nov 20, 2024

Merge activity

**Changes:**
Migrates from patch-package to pnpm patching for @cloudscape-design/board-components, adding custom CSS classes and className prop support.

Key updates:
- Removes patch-package dependency and postinstall script
- Adds pnpm patching configuration for @cloudscape-design/board-components
- Adds className prop support to Board component
- Adds custom CSS classes with bai_ prefix for board placeholders and grid items
@yomybaby yomybaby force-pushed the chore/pnpm-patch-react-project branch from 7d362f8 to 0822b3b Compare November 20, 2024 09:10
@graphite-app graphite-app bot merged commit 0822b3b into main Nov 20, 2024
6 checks passed
@graphite-app graphite-app bot deleted the chore/pnpm-patch-react-project branch November 20, 2024 09:12
@yomybaby yomybaby mentioned this pull request Nov 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the use of patch-package with pnpm
2 participants